Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Convert to wrapper for ccurl library #10

Open
todofixthis opened this issue Jun 16, 2017 · 3 comments
Open

Convert to wrapper for ccurl library #10

todofixthis opened this issue Jun 16, 2017 · 3 comments

Comments

@todofixthis
Copy link
Contributor

todofixthis commented Jun 16, 2017

Convert the extension into a wrapper for the official CCurl library.

This gets us a ton of goodies for free:

  • Crypto code is already/regularly vetted.
  • Any enhancements or fixes made to the CCurl library would automatically apply to us.
  • We'd be able to seamlessly incorporate PoW.
@furuame
Copy link

furuame commented May 18, 2018

Why don't just use ctypes to load the existing ccurl library to do PoW?

@todofixthis
Copy link
Contributor Author

That could work, too. Maybe better — as long as we can do a one-command install (i.e., pip install pyota[ccurl]), then I'm not too precious about how it works under the hood (:

@furuame
Copy link

furuame commented May 19, 2018

Is one-command install necessary? ccurl.interface.js also needs extra steps to build ccurl.
I'm not familiar with Python, but I am curious if there is a way to do these steps automatically.

If that's the case, pyota-ccurl only need implement an interface to load PoW library, which is like ccurl.interface.js.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants