Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release a new version of the gem??? #117

Closed
spovich opened this issue Apr 3, 2020 · 4 comments
Closed

release a new version of the gem??? #117

spovich opened this issue Apr 3, 2020 · 4 comments

Comments

@spovich
Copy link

spovich commented Apr 3, 2020

The last release was 4 years ago. The project seems to be actively maintained, so just wondering if there is a reason for no release?
@Adam21e
Copy link

Adam21e commented Apr 11, 2020

@spovich I did fork the gem and apply all the pull requests here:
https://github.com/ipaddress2-gem/ipaddress_2

Released it as a gem: ipaddress_2

@spovich
Copy link
Author

spovich commented Apr 12, 2020

@Adam21e great, thank you! Giving it a look now.

jivdhaliwal pushed a commit to ministryofjustice/staff-device-dns-dhcp-admin that referenced this issue Aug 24, 2020
Add ipaddress_2 gem
427d0ec 
The ipaddress_2 gem includes fixes that have been sitting in the master branch
of ipaddress_2 for years without a gem release. Specifically the issue of valid?
not validating ipv4 subnets correctly (ipaddress-gem/ipaddress#110)

In the ipaddress gem you get the following

IPAddress::valid? "10.0.0.0/24"
=> false

But in ipaddress_2 this has been resolved and you get

IPAddress::valid? "10.0.0.0/24"
=> true

ipaddress-gem/ipaddress#117
jivdhaliwal pushed a commit to ministryofjustice/staff-device-dns-dhcp-admin that referenced this issue Aug 24, 2020
@jivdhaliwal
Add ipaddress_2 gem
d6ff7c4 
The ipaddress_2 gem includes fixes that have been sitting in the master branch
of ipaddress_2 for years without a gem release. Specifically the issue of valid?
not validating ipv4 subnets correctly (ipaddress-gem/ipaddress#110)

In the ipaddress gem you get the following

IPAddress::valid? "10.0.0.0/24"
=> false

But in ipaddress_2 this has been resolved and you get

IPAddress::valid? "10.0.0.0/24"
=> true

ipaddress-gem/ipaddress#117
@Ri1a
Copy link

Ri1a commented Aug 12, 2021 •
edited
Loading

It would be great if a new version of this gem could be released... it's unusable at this point because of Issues like #107 or #110 where you must tweak stuff to get this gem properly working. Frustrating!

@jcoetzee jcoetzee mentioned this issue Mar 31, 2022
Closed
@sandstrom
Copy link
Collaborator

Tracking this here: #132

Closing this issue, as I'm going through and cleaning up some outstanding issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spovich @Adam21e @sandstrom @Ri1a