-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Hashicorp Vault with Drone #31
Comments
Drone has built-in Vault support now, FWIW. |
Oh, that's awesome! The use case was slightly different: having the secrets in Vault and having Kubernetes integrated with Vault means not having to worry about secrets being leaked during CI/CD. I'll take a look anyway! |
We use However, we do have scenarios where the helm release requires different user defined values per helm deploy, and current way of passing key value pairs in the drone pipeline is too verbose. For this, we are adding skuid/helm-value-store support, which is strictly for non-secrets. (and tied into AWS DynamoDb atm) I will open a PR, but doubt the functionality would benefit the majority of the user base of this plugin, thus I wonder if this should be split off in a different plugin? |
Actually, this has been a long time standing issue in my backlog. Truth is that if Helm supports plugins, we should make this |
I should approach it that way, idd helm value store does require a specific plugin config (yaml file) how would the drone-plugin pull that config |
scrap that - I need to re-read https://github.com/kubernetes/helm/blob/master/docs/plugins.md but it would eat CI time if plugins can't be baked into the drone-helm plugin image |
Ideally, we want to have secrets defined in Vault.
The plugin could receive a vault token/host pair and pull the secrets from there.
The text was updated successfully, but these errors were encountered: