Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: override the name of TAR archive with multiple files #131

Open
bluelovers opened this issue Jul 14, 2021 · 1 comment
Open

Feature: override the name of TAR archive with multiple files #131

bluelovers opened this issue Jul 14, 2021 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@bluelovers
Copy link

bluelovers commented Jul 14, 2021

Is your feature request related to a problem? Please describe.

https://share.ipfs.io/#/bafybeihrqpj2nf5ldxw7bw55dn2kt24nxgjltx42eoxmbwjrgdlddrfivm

allow rename download name by url

image

Describe the solution you'd like

?filename=xxxx

https://share.ipfs.io/?filename=xxxx#/bafybeihrqpj2nf5ldxw7bw55dn2kt24nxgjltx42eoxmbwjrgdlddrfivm

when it has only one file

replace ?filename=xxxx in download url in <1>

click <2> get filename as xxxx

when it has many file

click <2> get filename as xxxx

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

new URLSearchParams(window.location.search).get('filename')

Additional context
Add any other context or screenshots about the feature request here.

@bluelovers bluelovers added the need/triage Needs initial labeling and prioritization label Jul 14, 2021
@lidel
Copy link
Member

lidel commented Jul 30, 2021

Ok, my understanding of the request here is to add the ability to control the filename of TAR archive when multiple files are downloaded via "Download all" <2> button.

A sensible feature request. If someone had time to implement, PRs welcome.

Note:

  • Do not use ?filename= because query params are sent to the server and could influence caching.
  • I suggest something https://share.ipfs.io/#/<cid>#name#xxxx – this makes the name suffix optional and does not send it to server (part of window.location.hash) (also, make sure .tar.gz is appended if missing from the filename in URL)

@lidel lidel changed the title allow rename download name by url Feature: override the name of TAR archive with multiple files Jul 30, 2021
@lidel lidel added exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

2 participants