Revert blockservice sessions context #578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Jorropo
changed the title
Jorropo
force-pushed
the
revert-bad-sessions-changes
branch
from
d152c7c
to
0912ba3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 65.59% 65.56% -0.04%
==========================================
Files 207 207
Lines 25612 25579 -33
==========================================
- Hits 16801 16771 -30
+ Misses 7338 7336 -2
+ Partials 1473 1472 -1
|
This was referenced Feb 14, 2024
Jorropo
changed the base branch from
main
to
02-16-bitswap/network_split_Routing_in_two_in_interface
Jorropo
force-pushed
the
revert-bad-sessions-changes
branch
from
0912ba3
to
e21efeb
Compare
Jorropo
changed the base branch from
02-16-bitswap/network_split_Routing_in_two_in_interface
to
main
Jorropo
force-pushed
the
revert-bad-sessions-changes
branch
from
e21efeb
to
d8d7675
Compare
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 16, 2024
Keeps in sync with: - ipfs/boxo#578 - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
hacdias
force-pushed
the
revert-bad-sessions-changes
branch
from
d8d7675
to
66da324
Compare
hacdias
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.