Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging for deduplicated queries #729

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

gammazero
Copy link
Contributor

Also, added comment about why request context is not used in inProgressRequestStatus.

Would deduplicated requests be worth tracking with a prometheus gauge?

@gammazero gammazero requested a review from a team as a code owner November 27, 2024 00:05
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.38%. Comparing base (cdefbf2) to head (da0117e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...uting/providerquerymanager/providerquerymanager.go 70.00% 2 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   60.33%   60.38%   +0.05%     
==========================================
  Files         244      244              
  Lines       31017    31026       +9     
==========================================
+ Hits        18713    18734      +21     
+ Misses      10633    10621      -12     
  Partials     1671     1671              
Files with missing lines Coverage Δ
...uting/providerquerymanager/providerquerymanager.go 87.86% <70.00%> (-0.65%) ⬇️

... and 13 files with indirect coverage changes

Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not

@gammazero gammazero merged commit 33c7b9c into main Nov 27, 2024
15 checks passed
@gammazero gammazero deleted the log-deduplicated-queries branch November 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants