Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility for graphsync 2.1 protocol #376

Open
Tracked by #371
hannahhoward opened this issue Mar 29, 2022 · 0 comments
Open
Tracked by #371

Backward compatibility for graphsync 2.1 protocol #376

hannahhoward opened this issue Mar 29, 2022 · 0 comments

Comments

@hannahhoward
Copy link
Collaborator

hannahhoward commented Mar 29, 2022

Goals

If we are successful in building out the graphsync metadata requests, in order to ship it, we need to make it backward compatbile.

Suggested Implementation

I am inclined to defer to Libp2p versioning, even though I think it makes sense to wrap messages in a 2_1 header, wrather than try to do versioning with wrappers.

The actions to take are:

  • If I make a metadata only request to a peer, and in connecting we find out they only support 2.0 requests, just error.
  • You really don't need to do anything on the responder side, as it should only get 2.1 requests from 2.1 peers.
  • For all other types of requests, just downgrade to a 2.0 message if the peer only supports 2.0
  • I think that's it.
@hannahhoward hannahhoward changed the title Build backward compatibility for the 2.1 protocol when we are ready to ship Backward compatibility for graphsync 2.1 protocol Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant