Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include block size in metadata #377

Open
Tracked by #371
hannahhoward opened this issue Mar 31, 2022 · 1 comment
Open
Tracked by #371

Include block size in metadata #377

hannahhoward opened this issue Mar 31, 2022 · 1 comment

Comments

@hannahhoward
Copy link
Collaborator

hannahhoward commented Mar 31, 2022

For metadata only requests, it may prove quite useful to add a BlockSize field to metadata, so we can factor raw bytes into decisions about how far to look ahead with fetching untrusted blocks.

@rvagg
Copy link
Member

rvagg commented Apr 1, 2022

But we'd have to trust the peer to report the block size correctly, is that going to be a problem? I suppose we could check the size matches and abort requests if the peer reports anything wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants