Helia throws when adding a block if it is already pinned

[justin0mcateer]

When adding content to Helia and setting the 'pin' option to true, if a pin exists the add method will throw a generic error with the message 'Already Pinned'.

The throw is here:
https://github.com/ipfs/helia/blob/main/packages/utils/src/pins.ts#L75

A couple of thoughts:

1. If the content already exists and/or is already pinned, is this really an error? The goal of the client is to have the content pinned, if it is already pinned, the client desire is satisfied already, not unsatisfiable.
2. If an error must be thrown, providing a specific error type or enumeration that could be reliably checked against would be helpful. Checking against an arbitrary message string seems fragile.

[achingbrain]

This seems reasonable, if a thing is pinned, and you try to pin it, it makes sense for it to be a no-op.

When adding content to Helia and setting the 'pin' option to true

What Helia API are you calling that accepts a pin option?

[SgtPooki]

@justin0mcateer any update here? Can you provide repro code?

[github-actions]

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

[justin0mcateer]

In the first line of the original description, I mistakenly made reference to the interface of our code which uses/wraps the Helia library. The Helia API we are calling is 'pins.add', which I've linked to above. If the CID is already in the list of pinned blocks (in the Datastore), the code clearly throws.