feat: add republish record to ipns #745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
reviewed
Feb 27, 2025
| * | ||
| * The public key is optional if the record has an embedded public key. | ||
| */ | ||
| republishRecord(record: IPNSRecord, pubKey?: PublicKey, options?: RepublishRecordOptions): Promise<void> |
There was a problem hiding this comment.
stick pubKey into RepublishRecordOptions object?
| @@ -707,6 +721,33 @@ class DefaultIPNS implements IPNS { | |||
|
|
|||
| return unmarshalIPNSRecord(record) | |||
| } | |||
|
|
|||
| async republishRecord (record: IPNSRecord, pubKey?: PublicKey, options: RepublishRecordOptions = {}): Promise<void> { | |||
Comment on lines
+46
to
+50
| testCid = CID.parse('QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn') | ||
| rsaKey = await generateKeyPair('RSA') // RSA will embed the public key in the record | ||
| ed25519Key = await generateKeyPair('Ed25519') | ||
| rsaRecord = await createIPNSRecord(rsaKey, testCid, 1n, 24 * 60 * 60 * 1000) | ||
| ed25519Record = await createIPNSRecord(ed25519Key, testCid, 1n, 24 * 60 * 60 * 1000) |
There was a problem hiding this comment.
do we need to create all of these before each test? could we create them in the tests that use them?
There was a problem hiding this comment.
just a nit here, but testCid could probably be moved up into the describe block, and then the records and keys could be moved into individual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #744
Change checklist