-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs/example #560
base: main
Are you sure you want to change the base?
fix: docs/example #560
Conversation
fs.add is not a function "Invalid key type" key type must be specified https://github.com/libp2p/js-libp2p/blob/main/packages/keychain/src/keychain.ts#L157
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this - can you please swap refs to RSA keys to use Ed25519 keys instead?
fs.add is not a function "Invalid key type" key type must be specified Ed keys are preferred over RSA for new code https://github.com/libp2p/js-libp2p/blob/main/packages/keychain/src/keychain.ts#L157
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the changes are not made to the index.ts files, they will be overwritten. can you make the modifications to the index.ts files so our doc gen updates the readme.md?
fs.add is not a function
"Invalid key type" key type must be specified
https://github.com/libp2p/js-libp2p/blob/main/packages/keychain/src/keychain.ts#L157
fix: docs/example
Description
Two function calls need to be modified for the examples to work.
Notes & open questions
I will try to write tests that prove the issues
Change checklist