Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't redirect open tabs with *.localhost urls to public gateway #894

Closed
RubenKelevra opened this issue Jun 12, 2020 · 1 comment
Closed
Labels
status/duplicate A question or request for support

Comments

@RubenKelevra
Copy link

Describe the bug
If there's an open tab, with an URL like http://cluster.ipfs.io.ipns.localhost/ and refreshed while the local gateway is unavailable (detected by the plugin) there would be just an error page showing "err connection refused".

When URLs like this are open in a new tab, the same thing occurs.

To Reproduce
Steps to reproduce the behavior:

  1. Disable local gateway
  2. Click on a link like this
  3. See error "ERR_CONNECTION_REFUSED"

Expected behavior
The plugin will recognize the IPNS URL and the status of the local gateway and rewrite the URL to load it from a public gateway instead.

Screenshots
Screenshot_20200613_004939

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Brave
  • Version: 1.9.80 Chromium: 81.0.4044.138 (Official Build)
@RubenKelevra RubenKelevra added the need/triage Needs initial labeling and prioritization label Jun 12, 2020
@lidel lidel added status/duplicate A question or request for support and removed need/triage Needs initial labeling and prioritization labels Jun 13, 2020
@lidel
Copy link
Member

lidel commented Jun 13, 2020

Thank you for filling this. I believe this is a duplicate of #806, so closing this one.

(if we had IPFS-aware error page, user would be able to recover from this. we should not redirect to public HTTP server, unless user explicitly chose that)

@lidel lidel closed this as completed Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/duplicate A question or request for support
Projects
None yet
Development

No branches or pull requests

2 participants