Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve flaky e2e tests #2123

Open
SgtPooki opened this issue Jun 14, 2023 · 0 comments
Open

fix: solve flaky e2e tests #2123

SgtPooki opened this issue Jun 14, 2023 · 0 comments
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@SgtPooki
Copy link
Member

from https://github.com/ipfs/ipfs-webui/actions/runs/5264059194/jobs/9514890050#step:8:381

1) remote-api.test.js:228:5 › Remote API tests › API @ URL › should show full multiaddr on Status page 

    Test timeout of 90000ms exceeded.

    Error: page.waitForFunction: Target closed

      141 |       } catch (_) {}
      142 |       // await page.waitForFunction(`localStorage.getItem('ipfsApi') && localStorage.getItem('ipfsApi').includes('${endpoint}')`)
    > 143 |       await page.waitForFunction(endpoint => window.localStorage.getItem('ipfsApi') && window.localStorage.getItem('ipfsApi').includes(endpoint), endpoint)
          |                  ^
      144 |       return
      145 |     }
      146 |     await page.waitForFunction(() => window.localStorage.getItem('ipfsApi') === null)

        at waitForIpfsApiEndpoint (/home/runner/work/ipfs-webui/ipfs-webui/test/e2e/remote-api.test.js:143:18)
        at switchIpfsApiEndpointViaSettings (/home/runner/work/ipfs-webui/ipfs-webui/test/e2e/remote-api.test.js:123:11)
        at /home/runner/work/ipfs-webui/ipfs-webui/test/e2e/remote-api.test.js:229:7

    Pending operations:
      - page.waitForFunction at test/e2e/remote-api.test.js:143:18


  2) remote-api.test.js:234:5 › Remote API tests › API @ URL › should show full multiaddr on Settings page 

    Test timeout of 90000ms exceeded.

    Error: page.waitForFunction: Target closed

      141 |       } catch (_) {}
      142 |       // await page.waitForFunction(`localStorage.getItem('ipfsApi') && localStorage.getItem('ipfsApi').includes('${endpoint}')`)
    > 143 |       await page.waitForFunction(endpoint => window.localStorage.getItem('ipfsApi') && window.localStorage.getItem('ipfsApi').includes(endpoint), endpoint)
          |                  ^
      144 |       return
      145 |     }
      146 |     await page.waitForFunction(() => window.localStorage.getItem('ipfsApi') === null)

        at waitForIpfsApiEndpoint (/home/runner/work/ipfs-webui/ipfs-webui/test/e2e/remote-api.test.js:143:18)
        at switchIpfsApiEndpointViaSettings (/home/runner/work/ipfs-webui/ipfs-webui/test/e2e/remote-api.test.js:123:11)
        at /home/runner/work/ipfs-webui/ipfs-webui/test/e2e/remote-api.test.js:235:7

    Pending operations:
      - page.waitForFunction at test/e2e/remote-api.test.js:143:18


  2 flaky
    remote-api.test.js:228:5 › Remote API tests › API @ URL › should show full multiaddr on Status page 
    remote-api.test.js:234:5 › Remote API tests › API @ URL › should show full multiaddr on Settings page 
@SgtPooki SgtPooki added need/triage Needs initial labeling and prioritization help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked good first issue Good issue for new contributors kind/test Testing work kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/beginner Can be confidently tackled by newcomers and removed need/triage Needs initial labeling and prioritization labels Jun 14, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jun 14, 2023
@SgtPooki SgtPooki moved this from Needs Grooming to Planned / Backlog in IPFS-GUI (PL EngRes) Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

1 participant