ipfs-http-client dht functions throw exceptions too early

[phillmac]

Ping @alanshaw

• Package: ipfs-http-client

• Version: >41.0.0

Type: Bug

Severity: High

Description:

Calls to DHT functions e.g. findProvs() fail too quickly on encountering a type: 3 message from the ipfs node. This seems to be naive, as type 3 error messages are not fatal to the dht functions; very often a valid response is obtained after a type: 3 message. The example code below more often than not fails to discover any providers at all, with error messages such as Error: dial backoff or Error: failed to dial : all dials failed or Error: failed to dial : no good addresses. These are to be expected and should not abort the operation.
The effect is that the dht functions are rendered unusable because of the highly erratic nature of the errors and the unreliability of getting any results.

This change was implemented in version 41.0.1,
PR: ipfs-inactive/js-ipfs-http-client#1183

Steps to reproduce the error:

Code e.g.

const IPFS = require('ipfs-http-client')
const hashes = [
  "zdpuAuSAkDDRm9KTciShAcph2epSZsNmfPeLQmxw6b5mdLmq5",
  "zdpuAmm8YdN9eHmQ2WHNShrdLF58SYEsqzDRFsx5GrCDVmNLr",
  "zdpuAwo4v8f1NYbUpoPSmCCondF2UPeB7fEqmWPQZD9Ss9Kts",
  "zdpuAyJcWDGajL3XMJf5iRmMRwM1zwAp3u2d928gZgr3ED8EB",
  "zdpuAyx3MUm6ZtkvabuMqbBZpnoPqsnAhnDpcCPYj9tBCmXff"
]

const ipfs = IPFS()

async function findProvs(hash) {
  const providerList = []
  const find = ipfs.dht.findProvs(hash)  
  try {
    for await (const provider of find) {
      providerList.push(provider)
      console.log(provider)
    }
  } catch (err) {
    console.error(err)
  }
  return providerList
}

hashes.forEach(async function (h) {
  console.log(h, await findProvs(h))
})

[achingbrain]

@phillmac this should be resolved by #3001 - could you take a look at the changes on that PR and comment if anything’s been missed?