Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'should import car with roots but no blocks' test #94

Open
Tracked by #56
SgtPooki opened this issue Dec 15, 2022 · 1 comment
Open
Tracked by #56

fix 'should import car with roots but no blocks' test #94

SgtPooki opened this issue Dec 15, 2022 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Dec 15, 2022

see #83 (comment)

from @lidel

This is an important smoke-test we should not skip and fix sooner than later (i vaguely remember Filecoin genesis blocks were "special snowflakes" that forced IPLD team to course-correct some specs).

This test is re-enabled, but has part of it temporarily commented out.

// TODO: https://github.com/ipfs/js-kubo-rpc-client/issues/94 - This is failing. The error message is empty, but it should not be.
// expect(result[1].root.pinErrorMsg).to.be.a('string')
// expect(result[1].root.pinErrorMsg).to.not.be.empty('result[1].root.pinErrorMsg should not be empty')
// expect(result[0].root.pinErrorMsg).to.contain('ipld: could not find')

@SgtPooki SgtPooki added P0 Critical: Tackled by core team ASAP kind/bug A bug in existing code (including security flaws) labels Dec 15, 2022
@SgtPooki SgtPooki changed the title re-enable 'should import car with roots but no blocks' test fix 'should import car with roots but no blocks' test Dec 15, 2022
@tinytb
Copy link

tinytb commented Jan 17, 2023

We should consider removing the pinning tests from the RPC client. Tests should validate that the daemon receives the correct params; Kubo should ensure that it does the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

2 participants