Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian handler scripts - Copy or Submodule? #10475

Closed
twdragon opened this issue Aug 9, 2024 · 1 comment
Closed

Debian handler scripts - Copy or Submodule? #10475

twdragon opened this issue Aug 9, 2024 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@twdragon
Copy link
Contributor

twdragon commented Aug 9, 2024

After the successful launch of the unofficial Ubuntu PPA as an installation source (#10467), and some tests, here is my suggestion to add building of the Debian packages to the mainline Github Workflows CI. The maintainer scripts and build handler scripts are maintained now in the repository: https://github.com/twdragon/kubo-debian-pkg

The question is: Should I open the pull request to

  • Create the submodule containing the handler scripts within the original Kubo repository.
  • Copy the code from the Debian handler scripts repository to the Kubo repository and archive the original one.
@twdragon twdragon added the kind/enhancement A net-new feature or improvement to an existing feature label Aug 9, 2024
@lidel
Copy link
Member

lidel commented Aug 20, 2024

Closing, as we had discussion in #10479 and decided distribution-specific packaging pipelines need to live outside of this repository.

We are happy to add community-maintained packages in https://github.com/ipfs/kubo?tab=readme-ov-file#unofficial-linux-packages

Rationale in #10479 (review) and #10479 (comment)

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants