Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to GET find endpoints #1484

Open
masih opened this issue Mar 29, 2023 · 1 comment
Open

Add pagination to GET find endpoints #1484

masih opened this issue Mar 29, 2023 · 1 comment

Comments

@masih
Copy link
Member

masih commented Mar 29, 2023

We are already seeing a large number of records in response to lookup. This is most visible in the double hashing path. Example:

Related issue: #1005

@masih
Copy link
Member Author

masih commented Mar 30, 2023

Looking close at one of the providers in returned results:

/ip4/209.94.92.6/udp/24123/quic/p2p/12D3KooWHf7cahZvAVB36SGaVXc7fiVDoJdRJq42zDRcN2s2512h)

It advertises the following protocols:

/ipfs/id/1.0.0
/ipfs/id/push/1.0.0
/ipfs/ping/1.0.0
/libp2p/circuit/relay/0.1.0
/libp2p/circuit/relay/0.2.0/stop
/ipfs/bitswap/1.0.0
/p2p/id/delta/1.0.0
/ipfs/bitswap/1.2.0
/ipfs/bitswap/1.1.0
/ipfs/bitswap

Note that it does not list go-legs protocol ID, meaning the publisher of IPNI advertisements must differ from the provider.

1889 records returned for the same provider with BitSwap as metadata listed as different ContextIDs:

$ curl -s https://dev.cid.contact/multihash/QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn | jq '.MultihashResults[0].ProviderResults[]  | select(.Metadata=="gBI=") | .Provider | select(.ID =="12D3KooWHf7cahZvAVB36SGaVXc7fiVDoJdRJq42zDRcN2s2512h") | .ID'  | wc -l

1889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant