Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow multicast ranges in interface prefixes #1779

Closed
ipspace opened this issue Jan 8, 2025 · 0 comments
Closed

Disallow multicast ranges in interface prefixes #1779

ipspace opened this issue Jan 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@ipspace
Copy link
Owner

ipspace commented Jan 8, 2025

Based on #1777 (comment) by @jbemmel

However:

  • We still cannot use the same type check for regular and loopback prefixes
  • We cannot disallow multicast ranges in prefix checks as the prefix we check might be coming from a prefix-list

Either we implement the "interface IP address sanity check" later in the process (turning the check_host_bits into something more generic) or we implement tons of variations of the IPv4/IPv6 address type validation.

I think I'll go with the former even though in theory the type validation should catch more errors (because someone might forget to call the interface_address_sanity_check)

@ipspace ipspace added the bug Something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant