deprecate empty isidentifier utility (#915)

Author: minrk

traitlets/traitlets.py

@@ -170,6 +170,11 @@ class TraitError(Exception):
 
 
 def isidentifier(s: t.Any) -> bool:
+    warn(
+        "traitlets.traitlets.isidentifier(s) is deprecated since traitlets 5.14.4 Use `s.isidentifier()`.",
+        DeprecationWarning,
+        stacklevel=2,
+    )
     return t.cast(bool, s.isidentifier())
 
 
@@ -3025,7 +3030,7 @@ class ObjectName(TraitType[str, str]):
     def validate(self, obj: t.Any, value: t.Any) -> str:
         value = self.coerce_str(obj, value)
 
-        if isinstance(value, str) and isidentifier(value):
+        if isinstance(value, str) and value.isidentifier():
             return value
         self.error(obj, value)
 
@@ -3041,7 +3046,7 @@ class DottedObjectName(ObjectName):
     def validate(self, obj: t.Any, value: t.Any) -> str:
         value = self.coerce_str(obj, value)
 
-        if isinstance(value, str) and all(isidentifier(a) for a in value.split(".")):
+        if isinstance(value, str) and all(a.isidentifier() for a in value.split(".")):
             return value
         self.error(obj, value)