Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synproxy: TCP option 的处理 违反了 RFC9293 #924

Open
D-Wythe opened this issue Nov 23, 2023 · 1 comment
Open

synproxy: TCP option 的处理 违反了 RFC9293 #924

D-Wythe opened this issue Nov 23, 2023 · 1 comment
Assignees
@ywc689
Labels
issue/to-solve issues await answers tobe solved

Comments

@D-Wythe
Copy link

D-Wythe commented Nov 23, 2023 •
edited
Loading

目前 synproxy 会复用 SYN ，修改一些字段后发回给 client 作为 SYNACK。
无意义的反射TCP options回去，这种行为是RFC9293明确禁止的。
一些TCP option会将反射视作特定功能的协商完成。比如MPTCP，SMC
以及IETF工作组正在处理的一些的新选项。这会导致client对功能协商的结果判断出现异常，
严重的情况会导致部分TCP option 被错误的当作应用数据。

建议修改：
将synproxy中未知的TCP options 修改成 TCP_NOP， 这也不会对性能有很大的影响。
@ywc689 ywc689 self-assigned this Nov 24, 2023
@ywc689
Copy link
Collaborator

ywc689 commented Nov 24, 2023

好的，我看下这个问题

@ywc689 ywc689 added the issue/to-solve issues await answers tobe solved label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywc689 ywc689

Labels
issue/to-solve issues await answers tobe solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ywc689 @D-Wythe