Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iqlusioninc/yubikey.rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5e99c583e58ff2ae4b551a40e1423bfd0b5b39f3
Choose a base ref
..
head repository: iqlusioninc/yubikey.rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 654cc413c8875e80856cc724436af1b4b7675e28
Choose a head ref
Showing with 112 additions and 32 deletions.
  1. +107 −27 Cargo.lock
  2. +2 −2 cli/src/terminal.rs
  3. +3 −3 src/certificate.rs
134 changes: 107 additions & 27 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cli/src/terminal.rs
Original file line number Diff line number Diff line change
@@ -194,8 +194,8 @@ pub fn print_cert_info(
.oid,
)?;

print_cert_attr(stream, "Subject", &cert.tbs_certificate().subject())?;
print_cert_attr(stream, "Issuer", &cert.tbs_certificate().issuer())?;
print_cert_attr(stream, "Subject", cert.tbs_certificate().subject())?;
print_cert_attr(stream, "Issuer", cert.tbs_certificate().issuer())?;
print_cert_attr(
stream,
"Fingerprint",
6 changes: 3 additions & 3 deletions src/certificate.rs
Original file line number Diff line number Diff line change
@@ -455,20 +455,20 @@ pub mod yubikey_signer {
}
}

impl<'y, KT: KeyType> Keypair for Signer<'y, KT> {
impl<KT: KeyType> Keypair for Signer<'_, KT> {
type VerifyingKey = KT::VerifyingKey;
fn verifying_key(&self) -> <Self as Keypair>::VerifyingKey {
self.public_key.clone()
}
}

impl<'y, KT: KeyType> DynSignatureAlgorithmIdentifier for Signer<'y, KT> {
impl<KT: KeyType> DynSignatureAlgorithmIdentifier for Signer<'_, KT> {
fn signature_algorithm_identifier(&self) -> spki::Result<AlgorithmIdentifierOwned> {
self.verifying_key().signature_algorithm_identifier()
}
}

impl<'y, KT: KeyType> signature::Signer<KT::Signature> for Signer<'y, KT> {
impl<KT: KeyType> signature::Signer<KT::Signature> for Signer<'_, KT> {
fn try_sign(&self, msg: &[u8]) -> SigResult<KT::Signature> {
let data = KT::prepare(msg)?;