Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unittest.skipIf decorator into an assertion for some tests #591

Open
2 tasks
alanking opened this issue Jul 23, 2024 · 0 comments
Open
2 tasks

Change unittest.skipIf decorator into an assertion for some tests #591

alanking opened this issue Jul 23, 2024 · 0 comments
Labels

Comments

@alanking
Copy link
Contributor

alanking commented Jul 23, 2024

  • test_temporary_xml_mode_change_with_operation_as_proof__issue_586
  • test_setting_xml_parser_choice_by_environment_only__issue_584

From these review comments: #589 (comment) and #585 (comment)

These tests will be skipped if the environment in which the test is running is not found to be in the expected state. This could lead to the test being skipped unintentionally. If we want the test to always be run, we should assert that the environment has the expected conditions rather than skipping the test. Skipping the test could lead us to believe that all our tests are passing when in fact they are not, just because the testing environment is not in the expected state.

@alanking alanking changed the title test_temporary_xml_mode_change_with_operation_as_proof__issue_586: Change unittest.skipIf decorator into an assertion Change unittest.skipIf decorator into an assertion for some tests Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant