Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The used helper method will be called again when changing the URL even if the URL is not the same #1546

Open
qingdaojunzuo opened this issue Jul 14, 2016 · 0 comments

Comments

@qingdaojunzuo
Copy link

The code implemented in router_client.js: dispatch shown as below,

Line 96 : this._currentController = controller;
...
Line 141: if (this._currentController == controller)
Line 142 this._currentDep.changed();

If set created or old controller to current one on line 96, the check on line 141 is always true. Is this right? Or it is the design?

Currently, I see that the helper method will be called again when page changed even if the URL is not the same.
Do the helper methods or other autorun blocks need to be called again when page changed if URL is not the same?

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant