Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please not try to enumerate serial ports every time the extension loads? #16

Open
2 tasks done
Wuerfel21 opened this issue Feb 11, 2025 · 2 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@Wuerfel21
Copy link

and have you...

  • I updated to the latest spin2 version available
  • I have restarted VSCode and the problem still exists

Version of Spin2 Language Server VScode Extension with the issue

yes

Is this a regression?

Yes. This used to work, but now it doesn't.

Hardware, Operating System, Operating System version, VSCode version

The usual, Linux, etc

Description of problem

It's very annoying. I'm not even using the feature this enables, I always load from the CLI. Also it will apparently write whatever port it finds into the project-level settings.json. Please stop. Extensions that automatically edit settings.json / adjacent files in my project directories get THE WALL.

Additional information

No response

@Wuerfel21 Wuerfel21 added the bug Something isn't working label Feb 11, 2025
@ironsheep
Copy link
Owner

Geez, I thought I hid all of this behind the enable for the build system. I'll get this updated today/tomorrow.

Thanks for reporting this!

FYI- I used what was available for storage of this information. Would you have other suggestions for where to store this in the current project?

@Wuerfel21
Copy link
Author

Wuerfel21 commented Feb 12, 2025

Ideally you wouldn't write to the config automatically. The average user doesn't have any particular permanent port mapping, so the port may change from run to run anyways. In most cases beyond that, it's really a per-user setting - it really shouldn't be in the project files you may share / version control. Only when someone has multiple P2 boards hooked up at once would you need a per-project setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants