Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias support #1590

Open
ovalseven8 opened this issue Jun 27, 2016 · 10 comments
Open

Add alias support #1590

ovalseven8 opened this issue Jun 27, 2016 · 10 comments

Comments

@ovalseven8
Copy link

ovalseven8 commented Jun 27, 2016

At the moment, every client implements an own system how to save aliases for contacts. Because every client should support aliases (they are really important because of how Tox works), it would makes sense to add it to the .tox file.

If you use client X with aliases and export the Tox profile because you'd like to use it on another device, everybody expect that the names in the contact list are the same as before. But that's not the case currently.

Pros:
✅ It will be much easier for client developers to implement alias support
✅ Because of the consistent save system, import/export of a profile will be easier and more comfortable for the users
✅ Global alias support and no client patchwork rug solution

@GrayHatter
Copy link
Collaborator

👎

@GrayHatter
Copy link
Collaborator

they are really important because of how Tox works

why are they important, i.e. how does tox work?

@ProMcTagonist
Copy link
Contributor

@GrayHatter Usernames are not unique, or restricted in any meaningful way (which is how it should be). Aliases are therefore important to keep track of a contact across username changes, and to protect against impersonation.

@GrayHatter
Copy link
Collaborator

@ProMcTagonist you're correct, but with that you also explain why I don't want alias in toxcore*. Toxcore is meant to transfer (and to a very minor extent) store the information to and from your contacts. Unless you're also planning to send the alias to your friend.

It doesn't belong in toxcore.

The exception to that being, if someone wants to extend the save format / functions built into toxcore. That would be okay, because then you could add or remove sections at will.

@ovalseven8
Copy link
Author

At the moment, the names are already saved in the .tox file. It just makes sense to add also the aliases.

@GrayHatter
Copy link
Collaborator

no, names are in toxcore because toxcore provides an API to set and transfer names... aliases would be local only, that's the important difference

@ovalseven8
Copy link
Author

I just wanted to make clear that because of that alias support would make sense.

@ProMcTagonist
Copy link
Contributor

It sounds like aliases are in TCS domain, maybe depending on the expanded disguised zip save format that's been discussed

@GrayHatter
Copy link
Collaborator

GrayHatter commented Jun 29, 2016

As suggested in IRC by myself as well as @tux3, you could extend the toxcore save format.

Then you could call tox_apis to set and retrieve that information in a cross compatible way, without having to implement anything like it in Messenger

@ananace
Copy link

ananace commented Jul 5, 2016

One reason to implement it in core - or at least against core, would be to allow for syncing aliases between devices once multi device support is done.
Though that would probably still be more appropriate to do as a client-to-client protocol, not as part of the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants