Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide groups without a name #196

Closed
Nimmidev opened this issue Jun 24, 2022 · 3 comments
Closed

Option to hide groups without a name #196

Nimmidev opened this issue Jun 24, 2022 · 3 comments

Comments

@Nimmidev
Copy link

Nimmidev commented Jun 24, 2022

When using scli i have groups with weird names like "M4u70uK1FgpR83jSHWNBYcKne4DX/GtXjyIoFihxM5c=".
scli group names

After investigating a bit it seems like scli is using the group id if the name is null.

Output of signal-cli listGroups:
signal null groups

If this is intended behavior it would be great if there was an option to hide groups with no name. Especially because these groups are the ones you are no longer part of i.e. you cant use them anyways.

(I am not sure if this is actually an issue with signal-cli. So if you think such entries shouldn't be in the listGroups output anyways please tell me and i am gonna open an issue there.)

@exquo
Copy link
Collaborator

exquo commented Jul 6, 2022

More importantly than having Name: null, these groups are all Active: false. They are indeed groups that you are no longer a member of (see AsamK/signal-cli#975)

It would make sense to omit such groups from scli's contacts list if there is nothing else useful about them, such as the past conversation history. Generally, we should do the same here as the official clients.

@exquo
Copy link
Collaborator

exquo commented Feb 19, 2023

In line with following the official clients' behavior, signal-cli does not delete the group after leaving it (AsamK/signal-cli#975 (comment)). However, after leaving the group, its name in listGroups does not seem to change.

To delete such group from signal-cli's list (and, correspondingly, scli's too), you can use your master device (signal on the phone), or signal-cli directly. That is, until the quit / delete group functionality is added to scli.

@exquo exquo closed this as completed Feb 19, 2023
@exquo
Copy link
Collaborator

exquo commented Feb 22, 2023

Correction: seems like deleting a group is not sync'd across devices. So we do need an option to delete groups from scli. To not reopen this issue, tracking it in the new one: #210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants