Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote-deleted messages are not shown as deleted on a linked device #214

Closed
exquo opened this issue Feb 27, 2023 · 6 comments
Closed

Remote-deleted messages are not shown as deleted on a linked device #214

exquo opened this issue Feb 27, 2023 · 6 comments

Comments

@exquo
Copy link
Collaborator

exquo commented Feb 27, 2023

          okay, I tested the message deleting and

a message written from my phone can be deleted on both devices via scli
it only gets deleted on the phone when remote deleted via the phone

a message written from scli doesnt get deleted on my phone via scli remote delete
also it cannot even be remote deleted from my phone (no option for that, only for self deletion)

Oh okay
Sadly don't really understand the code, as i really like the UI :)

Originally posted by @meZeex in #210 (comment)

@exquo
Copy link
Collaborator Author

exquo commented Feb 27, 2023

Could not reproduce.. Tried for individual contacts and groups.

it only gets deleted on the phone when remote deleted via the phone

This is ambiguous, which of the two do you mean?

  • remote-delete the message on the phone -> message is not shown as deleted in scli
    (i.e. "it only gets deleted on the phone when remote deleted via the phone")
  • remote-delete the message from scli (with D) -> message is not shown as deleted on the phone
    (i.e. "it only gets deleted on the phone when remote deleted via the phone")

also it cannot even be remote deleted from my phone (no option for that, only for self deletion)

Could you be attempting this on the receiving device? Only the sender can "delete for everybody"

@ghost
Copy link

ghost commented Mar 7, 2023

Could you be attempting this on the receiving device? Only the sender can "delete for everybody"

Both Devices use the same account

phone deletes message sent from phone
=> message stays on scli

scli deletes message sent from phone
=> deleted on both devices

phone deletes message sent from scli
=> isn't allowed to delete it

scli deletes message sent from scli
=> message stays on phone

For my understanding, it's the same account, so i should be able to delete the message from any device linked to that account

This was tested in the 'notes to self' chat

@ghost
Copy link

ghost commented Mar 7, 2023

Okay, so i just realised that the 'note to self' chat has a different behaviour

When in a chat with another user, it works to get deleted from both devices, no matter where it was sent from

@exquo
Copy link
Collaborator Author

exquo commented Mar 14, 2023

Thanks for the clarification! The "to-self" messages might indeed behave differently.

FWIW, with Signal Desktop, only the "Signal Desktop not allowed to delete a message sent from scli" case applies; the others seem to work as expected (i.e. the messages do get deleted). And even the case above might be the intended behavior by the signal devs.

Is there a usage scenario for remote-deleting messages to self, or were those just for testing?

@ghost
Copy link

ghost commented Mar 21, 2023

i sometimes write notes to myself or send a text or link from device to device via the 'messages to self' chat, so it's nice when they can be deleted only once, but i guess it's okay knowing that it works that way

@exquo
Copy link
Collaborator Author

exquo commented Mar 23, 2023

Ok, then we can probably close this. Since:

  1. This is an upstream question: essentially all scli is doing here is calling signal-cli remoteDelete.
  2. This might even be the intended behavior, as messages-to-self are treated specially.

Just a note (but might be relevant here): signal-cli has an additional flag --note-to-self to "send the message to self without notification".

@exquo exquo closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant