Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conversations with non-contacts #61

Closed
jbg opened this issue May 9, 2020 · 2 comments
Closed

Allow conversations with non-contacts #61

jbg opened this issue May 9, 2020 · 2 comments

Comments

@jbg
Copy link

jbg commented May 9, 2020

I don't give the Signal app contact access, since Signal shows my conversation partners' chosen nicknames anyway. This works fine with the Signal mobile app and with signal-desktop, but with scli I am unable to converse with anyone since it only displays conversations for contacts.

Perhaps you could consider changing the left pane to show conversations rather than contacts? Or provide some other way to converse with people that are not in the contact list?

@isamert
Copy link
Owner

isamert commented Jun 24, 2020

For an easy solution, I may just go with the latter option. Like getting an input from the user (like phone number) and then scli may add that number to the left pane. Syncing earlier conversations from the phone may be problematic, this one seems like a better option.

@exquo
Copy link
Collaborator

exquo commented Jul 3, 2020

I've just experimented with exchanging messages with phone numbers that are not in my phone's contacts / address book. The result is that syncing conversations works the same as on signal-desktop (except that scli needs a restart to display those new conversations, but that should be a separate issue, see #71)

Here's what already works (i.e. after an action below, the "new" contacts' phone numbers are added to signal-cli's data file, loaded by scli at starttime, and are displayed in scli's contacts list; the messages received from them are also displayed normally):

  • Receiving a message from a 'new' number (one not in phone's contacts list and not from an existing prior conversation).
  • Being added to a group chat containing (or having exclusively) members with 'new' numbers.
  • Sending a message to a 'new' number from signal-android.
  • Ditto from signal-cli.

Functionality that's currently missing in scli:

  • Initiating a new conversation with a contact that's not in phone's contacts list.
  • Creating a new group chat.
  • Displaying the nickname chosen by the contact alongside / instead of just the phone number for contacts not in phone's address book.

BTW, signal-desktop does not provide the first two functions either.
It should be relatively straightforward to add the first one to scli (mostly a matter of adding the UI): signal-cli can take any phone number as a recipient and will automatically add the new number to its contactsStore. The second one is also possible through signal-cli - it has the updateGroup command to create new groups. The third does not look possible at the moment - signal-cli does not provide the nicknames information. I have opened a ticket for that in their repo AsamK/signal-cli#327.

I think this issue has not been meant to be about creating new groups, so I have opened a separate issue for that (#72). Then this one can be just about adding the functionality for messaging a new number. (And also for discussing any other required functionality that I haven't thought about)

exquo added a commit to exquo/scli that referenced this issue Sep 18, 2020
If contact's name in signal-cli's `contactStore` is absent, attempt to get contact's (self-chosen) profile name.
`profileStore` is available in signal-cli since v0.6.9. Profiles are requested only after signal-cli sends a message to a contact.

See also: isamert#61; AsamK/signal-cli#327
c-pec pushed a commit to c-pec/scli that referenced this issue Apr 20, 2022
Allow adding (individual) contacts to the contact list.
Closes isamert#61
c-pec pushed a commit to c-pec/scli that referenced this issue Apr 20, 2022
If contact's name in signal-cli's `contactStore` is absent, attempt to get contact's (self-chosen) profile name.
`profileStore` is available in signal-cli since v0.6.9. Profiles are requested only after signal-cli sends a message to a contact.

See also: isamert#61; AsamK/signal-cli#327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants