Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renaming contacts #74

Closed
exquo opened this issue Jul 11, 2020 · 2 comments
Closed

Allow renaming contacts #74

exquo opened this issue Jul 11, 2020 · 2 comments

Comments

@exquo
Copy link
Collaborator

exquo commented Jul 11, 2020

Signal-cli has an updateContact method that allows to change contact's name. It might be useful to be able to do this from scli. This command can also be used to create a new contact.

Like #72, this is mostly a matter of adding the UI. I don't know what would be the most natural way to do it, maybe have a pop-up 'edit contact' dialog bound to some keypress (e.g. e) when the cursor is over the contact's name? Or have a :renameContact command?

Signal-cli's updateContact only changes names locally, in its own database. It needs a sendContacts call to sync it with server. Maybe this should be added as an addiotonal button in the 'edit contact' pop-up window.

@isamert
Copy link
Owner

isamert commented Jul 11, 2020

I think a popup will complicate things. An :renameContact command would be a better fit. If commands become more discoverable, it would be even better. There is already a basic command completion with Tab key and basic contextual completion, like :attach ~/<TAB> would list files under your home folder. Likewise, :renameContact <TAB> would list all the possible contacts with incremental completion and the second argument would be the new contact name.

@exquo
Copy link
Collaborator Author

exquo commented Apr 11, 2021

It needs a sendContacts call to sync it with server.

From the sendContacts section of signal-cli's man page:

This command should only be used if this is the master device.

So if signal-cli is not master (e.g. has been linked with signal app on the phone), there is no way to update the contacts list on signal servers from signal-cli / scli..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants