Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to Plasma 6 #32

Open
ciachciarachciach666 opened this issue Feb 28, 2024 · 7 comments
Open

Porting to Plasma 6 #32

ciachciarachciach666 opened this issue Feb 28, 2024 · 7 comments

Comments

@ciachciarachciach666
Copy link

Hey ismailof,

Since this is the best media controller addon, are there any chances of it getting ported to Plasma 6?

Thanks!

@ismailof
Copy link
Owner

ismailof commented Mar 4, 2024

I'll start with a bit of digression:

For media players in particular there are two points that require porting:

  • The general plasmoid API changes for Plasma 6: this is already done
  • The deprecation of the previous Media interface (mpris) from using DataEngines, which got deprecated and replaced by a new plugin.

Were only for the first part, I would have publish the current porting work. But the second point is a bit more tedious, and probably the easiest way is to copy the changes from the official plasmoid.

At this point the official applet already offers two of the characteristics why I started this "fork": panel representation with the song info, and icon tabbar for different players. So I'm wondering if the effort would be best invested into adding the last remaining bits to the official applet (options for formatting the panel view, and panel controls) instead of the inverse.

So, TLDR, I cannot promise there will be a ported version soon :) but I'm considering it.

Thanks for your interest!

@ciachciarachciach666
Copy link
Author

Thanks a lot for the detailed answer! TBH for me the most important parts are control buttons on the taskbar. I've checked and there are no plasmoids with that functionality yet.

@MurzNN
Copy link

MurzNN commented Mar 5, 2024

The same for me, control buttons on the panel is the thing!

@metzger100
Copy link

I don't know if it helps, but I guess that most of the users of "mediacontroller plus" are using it because of the panel controls. The official applet is very limited (There isn't even a settings page). I like the official applet but the missing panel controls are a game breaker for me. On the other side I always had problems with "mediacontroller plus" while using brave browser and the spotify flatpak (other flatpaks had the same problem). The automatic player tab never got it right and selected the paused youtube video in the browser instead of the running spotify song. The official applet is working flawlessly in this case. In my humble opinion an upgrade of the official applet would be better than an update of mediacontroller plus.

@jediafr
Copy link

jediafr commented Mar 16, 2024

@ismailof
I reverted back to plasma 5 for your widget (and alias). Your widget takes the all menu available space, let me adjust the volume by scrolling in there and have the controls icons also, it is very readable and i keep track of the song progression visually. Please consider porting it , it is that awesome !
Some plasma 6 have some of that but not all

@UserFooBar
Copy link

UserFooBar commented Mar 24, 2024

Loved it on plasma 5, it's really a shame not to see it on plasma 6. The buttons on the media player are super useful

@ReillyBrogan
Copy link

I think that adding the improvements to the upstream widget is the "correct" approach as it will bring the improvements to the most users. However, it also means that the changes wouldn't be available until Plasma 6.1 at minimum which is not ideal. Perhaps use this project as a "staging" area to get those ready for upstreaming before opening MRs to add the improvements to the original widget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants