Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retunn values of docker_run_file and docker_run_code differ #3

Open
nuest opened this issue Jan 13, 2020 · 2 comments
Open

Retunn values of docker_run_file and docker_run_code differ #3

nuest opened this issue Jan 13, 2020 · 2 comments

Comments

@nuest
Copy link
Contributor

nuest commented Jan 13, 2020

IMO docker_run_code and docker_run_file should have the same return type, but the former returns the output of docker$container$run(..) but the latter the result of container$exec(c("Rscript", docker_file_path)).

This makes it harder to use the same code to process the functions' return values.

@nuest
Copy link
Contributor Author

nuest commented Jan 13, 2020

See the test, one checks result$logs, but the other result$output: https://github.com/nuest/altRnative/blob/master/tests/testthat/test-run.R

@ismailsunni
Copy link
Owner

Hi @nuest
Yes, I 100% agree it should have the same output. I will try to make the uniform after the dust is settled :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants