Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation lacks namespaces #71

Closed
baukezwaan opened this issue Sep 8, 2020 · 1 comment
Closed

documentation lacks namespaces #71

baukezwaan opened this issue Sep 8, 2020 · 1 comment

Comments

@baukezwaan
Copy link

It seems the yml-examples lack the correct notation of the Extensions.

For example:

  extensions:
    - CatalogPageExtension
  parent_classes:
    - CatalogParentPage

should be:

  extensions:
    - LittleGiant\CatalogManager\Extensions\CatalogPageExtension
  parent_classes:
    - LittleGiant\CatalogManager\Extensions\CatalogParentPage

Or did I missed something, that it would work without namespaces in the YML?

@baukezwaan
Copy link
Author

Sorry, see there was already a PR to fix this:

#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant