You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug Description
Certain lists with markdown content and linebreaks don't render as expected in the actual site, even though the preview appears correctly.
To Reproduce
Steps to reproduce the behavior:
Go to the CMS
Click on My Workspace
Paste the following chunk in the editor and note how it looks then click save.
This is number one
**something**
Do you want cookies
```
Cookie monster
```
a. i love cookies
Go to the staging site and compare
Expected behavior
The numbers should not be reseted after a markdown chunk (here, the bolded portion). Instead, the numbers should continue normally.
Screenshots
preview render
site render
Note that both the font in the codebox as well as the numbering are reset.
Possible Causes
the default engine that jekyll uses is actually github flavoured markdown. this leads to multiple differences between actual markdown rendered text and gfm rendered text, which results in the differences shown above.
Possible Fixes
we could change our markdown parser to kramdown/markdown, which should solve this issue. however, this means that sites that use these quirks will experience a visual regression.
we could just inform the users of the fix. the differences between rendered/actual text don't really come up (~1 every few months) so it's not really a core issue. we can instead show users how to fix these issues due to the low rate of occurrence.
This issue will not be tackled now due to its low importance (low rate of related tickets).
The text was updated successfully, but these errors were encountered:
the frontend renders the html using markedjs, which has the gfm option set to true by default. this means that functionally, there should not be any difference between the actual/preview sites.
from the above, the main culprit is likely to be the converter
Bug Description
Certain lists with markdown content and linebreaks don't render as expected in the actual site, even though the preview appears correctly.
To Reproduce
Steps to reproduce the behavior:
My Workspace
Expected behavior
The numbers should not be reseted after a markdown chunk (here, the bolded portion). Instead, the numbers should continue normally.
Screenshots
preview render
site render
Note that both the font in the codebox as well as the numbering are reset.
Possible Causes
the default engine that jekyll uses is actually github flavoured markdown. this leads to multiple differences between actual markdown rendered text and gfm rendered text, which results in the differences shown above.
Possible Fixes
This issue will not be tackled now due to its low importance (low rate of related tickets).
The text was updated successfully, but these errors were encountered: