Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value for timed_spam_max to null #23

Open
ThomasLandauer opened this issue Apr 22, 2020 · 0 comments
Open

Change default value for timed_spam_max to null #23

ThomasLandauer opened this issue Apr 22, 2020 · 0 comments

Comments

@ThomasLandauer
Copy link
Contributor

If the session has expired, validation always fails, right? See https://github.com/isometriks/IsometriksSpamBundle/blob/master/Form/Extension/Spam/Provider/SessionTimedSpamProvider.php#L35

So I would set the default for timed_spam_max to null, so that the user's default session timeout setting (i.e. session.gc_maxlifetime in php.ini) kicks in. Otherwise, people keeping the default, will have 2 different timeout settings in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant