From 446e4a5af9ae6a6e13cd600089a3d63bcd5977e9 Mon Sep 17 00:00:00 2001 From: Craig Box Date: Fri, 10 Nov 2023 14:50:20 +1300 Subject: [PATCH] GRPC-WEB is a valid port protocol, but not listed (#2986) * GRPC-WEB is a valid port protocol, but not listed correctly in the docs. Adopted from https://github.com/istio/istio.io/pull/10942. * Add generated files --- networking/v1alpha3/gateway.pb.go | 2 +- networking/v1alpha3/gateway.pb.html | 2 +- networking/v1alpha3/gateway.proto | 2 +- networking/v1beta1/gateway.pb.go | 2 +- networking/v1beta1/gateway.proto | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/networking/v1alpha3/gateway.pb.go b/networking/v1alpha3/gateway.pb.go index 8ae66a8a59b..9c1a60d1803 100644 --- a/networking/v1alpha3/gateway.pb.go +++ b/networking/v1alpha3/gateway.pb.go @@ -913,7 +913,7 @@ type Port struct { // A valid non-negative integer port number. Number uint32 `protobuf:"varint,1,opt,name=number,proto3" json:"number,omitempty"` // The protocol exposed on the port. - // MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS. + // MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS. // TLS can be either used to terminate non-HTTP based connections on a specific port // or to route traffic based on SNI header to the destination without terminating the TLS connection. Protocol string `protobuf:"bytes,2,opt,name=protocol,proto3" json:"protocol,omitempty"` diff --git a/networking/v1alpha3/gateway.pb.html b/networking/v1alpha3/gateway.pb.html index 9ef04d09e2b..a2dfa29667e 100644 --- a/networking/v1alpha3/gateway.pb.html +++ b/networking/v1alpha3/gateway.pb.html @@ -618,7 +618,7 @@

Port

string

The protocol exposed on the port. -MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS. +MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS. TLS can be either used to terminate non-HTTP based connections on a specific port or to route traffic based on SNI header to the destination without terminating the TLS connection.

diff --git a/networking/v1alpha3/gateway.proto b/networking/v1alpha3/gateway.proto index 7462bbc3e59..319539c900c 100644 --- a/networking/v1alpha3/gateway.proto +++ b/networking/v1alpha3/gateway.proto @@ -597,7 +597,7 @@ message Port { uint32 number = 1 [(google.api.field_behavior) = REQUIRED]; // The protocol exposed on the port. - // MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS. + // MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS. // TLS can be either used to terminate non-HTTP based connections on a specific port // or to route traffic based on SNI header to the destination without terminating the TLS connection. string protocol = 2 [(google.api.field_behavior) = REQUIRED]; diff --git a/networking/v1beta1/gateway.pb.go b/networking/v1beta1/gateway.pb.go index 69430d06a2f..e3b6cdc53af 100644 --- a/networking/v1beta1/gateway.pb.go +++ b/networking/v1beta1/gateway.pb.go @@ -913,7 +913,7 @@ type Port struct { // A valid non-negative integer port number. Number uint32 `protobuf:"varint,1,opt,name=number,proto3" json:"number,omitempty"` // The protocol exposed on the port. - // MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS. + // MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS. // TLS can be either used to terminate non-HTTP based connections on a specific port // or to route traffic based on SNI header to the destination without terminating the TLS connection. Protocol string `protobuf:"bytes,2,opt,name=protocol,proto3" json:"protocol,omitempty"` diff --git a/networking/v1beta1/gateway.proto b/networking/v1beta1/gateway.proto index 2b3bcf7155b..c289154e08d 100644 --- a/networking/v1beta1/gateway.proto +++ b/networking/v1beta1/gateway.proto @@ -597,7 +597,7 @@ message Port { uint32 number = 1 [(google.api.field_behavior) = REQUIRED]; // The protocol exposed on the port. - // MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS. + // MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS. // TLS can be either used to terminate non-HTTP based connections on a specific port // or to route traffic based on SNI header to the destination without terminating the TLS connection. string protocol = 2 [(google.api.field_behavior) = REQUIRED];