Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "contents" button to make docs TOC appear broken at <1200px #16011

Open
craigbox opened this issue Nov 26, 2024 · 3 comments
Open

bug: "contents" button to make docs TOC appear broken at <1200px #16011

craigbox opened this issue Nov 26, 2024 · 3 comments
Assignees

Comments

@craigbox
Copy link
Contributor

craigbox commented Nov 26, 2024

Up to 1200px, there is a floating "Contents" button which is missing its hamburger icon:

Screenshot 2024-11-26 at 6 11 00 PM

When you click it to expand the contents, you can't make the pane go away again.

Screenshot 2024-11-26 at 6 16 25 PM
@craigbox
Copy link
Contributor Author

craigbox commented Nov 26, 2024

/cc @Arhell in case you fancy a look at this. I think for the Contents menu it's the same bug you fixed recently

@craigbox
Copy link
Contributor Author

Actually, the cross is there on the main site, but not in my deploy preview for some reason

compare https://deploy-preview-16010--preliminary-istio.netlify.app/latest/docs/ with istio.io, which looks like this

Screenshot 2024-11-26 at 6 13 33 PM

@Arhell Arhell self-assigned this Nov 26, 2024
@craigbox
Copy link
Contributor Author

The problem seems to be related to SVG sprites and Chrome. It works fine in Safari. I tried adding href to the SVG template as well as xlink:href, as is required by SVG 2.0, and I also tried setting a doctype of SVG 1.1. Neither changed anything locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants