Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax "errors" and formatting inconsistencies #104

Open
devtobi opened this issue Jan 23, 2025 · 0 comments
Open

Syntax "errors" and formatting inconsistencies #104

devtobi opened this issue Jan 23, 2025 · 0 comments

Comments

@devtobi
Copy link
Member

devtobi commented Jan 23, 2025

I found various wrong syntax usages in the action files (workflow files might be affected as well).
One example would be the definition of type for action inputs. This is actually not possible in actions (but just in workflows). See https://docs.github.com/en/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#inputs for more information.
Also number inputs aren't really numbers internally so should be written as string.

Another example is the interpolation of variables.
In some cases those look like this ${{ inputs.node-version }} (with spaces) or like this ${{inputs.app-path}} (without spaces).

We should try to keep it consistent in the future and adhere to the syntax definition of GitHub (although the syntax is pretty strange in some places).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant