From cd4bd150ece67f20d644cdce8f2e9e682e0b968f Mon Sep 17 00:00:00 2001
From: Simon Hirtreiter <14137977+simonhir@users.noreply.github.com>
Date: Thu, 31 Oct 2024 16:02:28 +0100
Subject: [PATCH] :sparkles: gateway use pmd module (#245)

---
 refarch-gateway/pom.xml      | 10 ++++++++-
 shared-files/pmd-ruleset.xml | 40 ------------------------------------
 2 files changed, 9 insertions(+), 41 deletions(-)
 delete mode 100644 shared-files/pmd-ruleset.xml

diff --git a/refarch-gateway/pom.xml b/refarch-gateway/pom.xml
index 88becac8..4d24c80f 100644
--- a/refarch-gateway/pom.xml
+++ b/refarch-gateway/pom.xml
@@ -25,6 +25,7 @@
 
         <!-- Core Frameworks -->
         <spring-cloud.version>2023.0.3</spring-cloud.version>
+        <refarch-tools.version>1.0.0</refarch-tools.version>
 
         <!-- Logging -->
         <logstash-logback-encoder.version>8.0</logstash-logback-encoder.version>
@@ -265,7 +266,7 @@
                         <excludeRoot>target/generated-test-sources</excludeRoot>
                     </excludeRoots>
                     <rulesets>
-                        <ruleset>../shared-files/pmd-ruleset.xml</ruleset>
+                        <ruleset>refarch-pmd-ruleset.xml</ruleset>
                     </rulesets>
                 </configuration>
                 <executions>
@@ -276,6 +277,13 @@
                         </goals>
                     </execution>
                 </executions>
+                <dependencies>
+                    <dependency>
+                        <groupId>de.muenchen.refarch.tools</groupId>
+                        <artifactId>refarch-pmd</artifactId>
+                        <version>${refarch-tools.version}</version>
+                    </dependency>
+                </dependencies>
             </plugin>
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
diff --git a/shared-files/pmd-ruleset.xml b/shared-files/pmd-ruleset.xml
deleted file mode 100644
index 9fd620b7..00000000
--- a/shared-files/pmd-ruleset.xml
+++ /dev/null
@@ -1,40 +0,0 @@
-<?xml version="1.0"?>
-
-<ruleset name="Custom Rules"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
-
-    <description>
-        Custom Ruleset
-    </description>
-    <rule ref="category/java/bestpractices.xml">
-        <exclude name="GuardLogStatement"/>
-        <exclude name="UnitTestContainsTooManyAsserts"/>
-        <exclude name="UnitTestAssertionsShouldIncludeMessage"/>
-    </rule>
-    <rule ref="category/java/codestyle.xml">
-        <exclude name="AtLeastOneConstructor"/>
-        <exclude name="LongVariable"/>
-        <exclude name="OnlyOneReturn"/>
-        <exclude name="ShortVariable"/>
-    </rule>
-    <rule ref="category/java/design.xml">
-        <exclude name="AvoidCatchingGenericException"/>
-        <exclude name="AvoidThrowingRawExceptionTypes"/>
-        <exclude name="ExcessiveImports"/>
-        <exclude name="LoosePackageCoupling" />
-        <exclude name="LawOfDemeter"/>
-        <exclude name="SignatureDeclareThrowsException"/>
-        <exclude name="TooManyMethods"/>
-    </rule>
-    <rule ref="category/java/errorprone.xml"/>
-    <rule ref="category/java/security.xml"/>
-    <rule ref="category/java/multithreading.xml">
-        <exclude name="UseConcurrentHashMap"/>
-    </rule>
-    <rule ref="category/java/bestpractices.xml/UnitTestShouldIncludeAssert">
-        <properties>
-            <!-- From Spring WebTestClient -->
-            <property name="extraAssertMethodNames" value="expectStatus,expectHeader" />
-        </properties>
-    </rule>
-</ruleset>