refarch-cli/.prettierignore (1)

1-3: Consider adding more common ignore patterns.

While the current patterns cover the basics, consider adding these common patterns to ensure comprehensive coverage:

 dist
 target
 node_modules
+coverage
+*.log
+.env*

refarch-cli/.npmrc (1)

1-2: Document security implications in README

Since this configuration affects lockfile content and package source verification, it would be helpful to document these implications in the project's README.

Consider adding a section in the README that explains:

• Why this configuration was chosen
• What it means for users installing the package
• Any potential security considerations when using the scaffolding tool

refarch-cli/tsconfig.json (2)

11-11: Consider adding test files to exclude list

The exclude configuration is good for build artifacts and dependencies, but consider also excluding test files if they exist.

-  "exclude": ["node_modules", "./dist/**/*"]
+  "exclude": ["node_modules", "./dist/**/*", "**/*.test.ts", "**/*.spec.ts"]

---

1-12: Consider additional TypeScript configurations for CLI development

Since this is a CLI tool, consider adding these configurations to enhance development:

   "compilerOptions": {
+    "strict": true,
+    "resolveJsonModule": true,
+    "allowJs": true,
     // ... existing config
   }

Rationale:

• strict: true - Enables all strict type checking options
• resolveJsonModule - Useful for importing package.json or config files
• allowJs - Helpful if mixing JavaScript and TypeScript during development

refarch-cli/rollup.config.js (1)

13-18: Consider enabling source maps for better debugging.

The plugins configuration is correct, but adding source map support would improve the debugging experience.

Consider updating the TypeScript plugin configuration:

-    typescript(),
+    typescript({
+      sourceMap: true,
+      inlineSources: true
+    }),

.gitignore (1)

35-36: Consider adding more Node.js and Rollup-specific patterns.

Since this is a Node.js project using Rollup, consider adding these commonly ignored patterns:

 # Node
 node_modules
+# Logs
+logs
+*.log
+npm-debug.log*
+
+# Coverage directory used by tools like Istanbul
+coverage
+
+# Rollup build outputs
+.rollup.cache/
+
+# Environment variables
+.env
+.env.local

refarch-cli/eslint.config.js (2)

8-14: Consider adding more common ignore patterns

While the current ignore patterns are good, consider adding more common patterns for a Node.js CLI tool.

    ignores: [
      "**/build/**",
      "**/dist/**",
      "index.js",
      "eslint.config.js",
      "rollup.config.js",
+     "**/node_modules/**",
+     "coverage/**",
+     ".git/**"
    ],

---

32-32: Consider broadening the file patterns

The current configuration only targets index.ts. As the project grows, you might want to lint all TypeScript files.

-   files: ["index.ts"],
+   files: ["**/*.ts"],

refarch-cli/package.json (1)

5-9: Add essential npm scripts

Consider adding the following scripts:

• test: For running tests
• prepare: For building the package during installation
• clean: For cleaning the dist directory before build

Apply this diff to add the suggested scripts:

  "scripts": {
+   "clean": "rm -rf dist",
-   "build": "rollup -c",
+   "build": "npm run clean && rollup -c",
    "lint": "prettier . --check && eslint . ",
-   "fix": "prettier . --write && eslint . --fix"
+   "fix": "prettier . --write && eslint . --fix",
+   "test": "echo \"No tests specified\" && exit 1",
+   "prepare": "npm run build"
  },

refarch-cli/index.ts (4)

18-18: Typo in comment: 'Projekt' should be 'Project'

In the comment at line 18, 'Projekt' should be corrected to 'Project' to fix the typo.

---

23-23: Clarify the selection message for better user understanding

The message "Select Project you want to generate with enter" could be clearer. Consider rephrasing it to "Select the project you want to generate and press enter".

---

130-130: Use forEach instead of map when not using the returned array

At line 130, using map without utilizing the returned array is less efficient. Use forEach instead.

Apply this diff to improve the code:

-  replacements.map((options) => replaceInFileSync(options));
+  replacements.forEach((options) => replaceInFileSync(options));

---

207-207: Use forEach instead of map when not using the returned array

At line 207, using map without utilizing the returned array is inefficient. Use forEach instead.

Apply this diff to improve the code:

-  replacements.map((options) => replaceInFileSync(options));
+  replacements.forEach((options) => replaceInFileSync(options));

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify package declaration and npm registry availability

# Check if package is declared in package.json
echo "Checking package.json for @muenchen/prettier-codeformat..."
rg -A 1 -B 1 "@muenchen/prettier-codeformat" package.json

# Check npm registry for package info
echo "Checking npm registry for package..."
curl -s https://registry.npmjs.org/@muenchen/prettier-codeformat | jq '.["dist-tags"].latest'

#!/bin/bash
# Let's check the actual package.json file location and content
fd -t f "package.json"

# Once we find the package.json, let's examine its dependencies
echo "Content of package.json files:"
fd -t f "package.json" -x cat {}

#!/bin/bash
# Check if package.json has types field and if the CLI is meant to be programmatically consumed
cat package.json | jq '.types, .exports, .bin'

# Check if there are any TypeScript imports of this package in the codebase
rg -l "from ['\"](scaffolding-refarch|@[^/]+/scaffolding-refarch)['\"]" -g "*.ts"

#!/bin/bash
# Let's first find the package.json file as it might be in a subdirectory
fd package.json

# Let's also check if there are any .d.ts files being generated
fd "\.d\.ts$"

# Check the tsconfig.json content to see current declaration settings
cat refarch-cli/tsconfig.json

#!/bin/bash
# Let's check the package.json content to see if this is meant to be a CLI-only tool
cat refarch-cli/package.json

# Let's also check if there are any TypeScript files that export public APIs
rg "export" -g "*.ts" -l refarch-cli/src/

#!/bin/bash
# Description: Verify the entry point file exists and contains CLI-related code

# Check if index.ts exists
if [ -f "refarch-cli/index.ts" ]; then
    echo "Entry point exists"
    # Look for CLI-related imports/code
    rg -l "commander|yargs|cli|prompt" "refarch-cli/index.ts"
else
    echo "Entry point missing"
fi

#!/bin/bash
# Check the content of index.ts to verify CLI setup
cat refarch-cli/index.ts

    rules: {
-     "no-console": "error",
+     "no-console": ["error", { allow: ["info", "error", "warn"] }],
      "no-unused-vars": "off",
      "@typescript-eslint/no-unused-vars": ["error"],
    },

#!/bin/bash
# Check if the codebase uses console statements for user feedback
rg "console\." --type ts

#!/bin/bash
# Let's try a broader search for console statements in all file types
rg "console\." -l

# Also check for any logging utilities or custom logger implementations
rg -i "log\(" -l

#!/bin/bash
# Let's check if there are any source files in the repository
fd -t f -e ts -e js -e tsx -e jsx

# Also check the package.json to understand the project type
cat package.json 2>/dev/null || echo "No package.json found"

#!/bin/bash
# Let's examine the content of index.ts to understand how the CLI tool handles output
cat refarch-cli/index.ts

-   "eslint-plugin-tsdoc": "^0.3.0",
+   "eslint-plugin-tsdoc": "0.3.0",

-   "eslint-plugin-tsdoc": "^0.3.0",
+   "eslint-plugin-tsdoc": "0.4.0",

#!/bin/bash
# Install dependencies in a temporary directory and check for warnings
TEMP_DIR=$(mktemp -d)
cd "$TEMP_DIR"
echo '{"name":"temp","version":"1.0.0"}' > package.json
npm install --package-lock-only $(cat /workspace/refarch-cli/package.json | jq -r '.devDependencies | to_entries | map("\(.key)@\(.value)") | .[]') 2>&1 | grep -i "warn"

#!/bin/bash
# Let's verify if the package.json exists and check its content
fd -t f "package.json" --exec cat {}

#!/bin/bash
# Check npm registry for eslint-plugin-tsdoc package info
npm view eslint-plugin-tsdoc time --json | jq -r 'to_entries | .[] | select(.key != "modified" and .key != "created") | "\(.key): \(.value)"' | sort -V | tail -n 5

# Check for any deprecation notices
npm view eslint-plugin-tsdoc deprecated