-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shortcut for parent action doesn't show palette #14
Comments
That's a nice catch. When I implemented parent actions I didn't consider that they could be triggered by keyboard shortcuts. I'll need to look into whether we should change the types to prevent passing keyboard shortcut or should we open the pallette with the parent action selected |
So I just tried adding
I think the parent actions might function more intuitively with a different shape & behavior. I propose:
|
Here's the use case I'm currently building:
SketchCommand.mp4 |
the way the API is designed is that a child action has the info that it's a nested action because it has parentActionId. However parent doesn't have any such info. So I went with the approach that parent actions should not have a run function because their only behaviour is to show its child actions. So when you added a run function, the action no longer remained a parent action. I'll try to surface this in docs, JSDoc comments so it appears on hover. Regarding only showing top level actions by default I think that makes sense. The reason it was like this was I wanted actions across all levels to be searchable. But since the model and view are decoupled I think this can be implemented. In case you'd like to contribute, let me know |
I can take a look at it. Can you point me in the direction of some good starting points for this? What do you think about having a separate |
As I see there are two tasks
I'm guessing by In case you meant just like we have |
RE: Also, I'm working on this now and ran into test failures after implementing the first task. I reverted the changes, and found that the tests fail even with no changes on my end. My OS is Windows 10, in case that has anything to do with it. |
I just submitted PR #15 |
🙌 SketchCommand-2.mp4 |
awesome!!! Regarding the E2E tests, I'll re-run them on my local once more to see if they are failing there too. |
RE: E2E I managed to run them successfully via the Playwright extension for VSCode. Dunno why they were failing via the CLI, maybe something to do with the additional browsers. |
This happened to me too. |
Example
Expected
Pressing
ctrl + g
will show the command palette, immediately loading thePages
list.Actual
Pressing
ctrl + g
does not show the command palette.The
Pages
list is loaded, but it is not visible until the command palette is toggled withctrl + k
.The text was updated successfully, but these errors were encountered: