Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of peer-dependencies should be specified #22

Open
on3iro opened this issue Jun 25, 2023 · 4 comments
Open

Version of peer-dependencies should be specified #22

on3iro opened this issue Jun 25, 2023 · 4 comments

Comments

@on3iro
Copy link

on3iro commented Jun 25, 2023

Hey folks,

again, following the example from the README I ran into an issue, where a newer version of tinykey does no longer have a default export. If I am not mistaken the hint to install peer dependencies should be unnecessary, as they should be installed automatically. However if you want users to install them manually, the correct version should be specified inside the README :)

I am also receiving an error with tinykeys:

TypeError: t2.trim is not a function. (In 't2.trim()', 't2.trim' is undefined)

In general it would probably make sense to update dependencies - if you want me to, I could create a PR.

@itaditya
Copy link
Owner

PR would be appreciated. Thanks @on3iro

@lominming
Copy link

I'm also hitting t2.trim is not a function error. I can't trace exactly where it is yet because the stackblitz demo works. Weirdly could be possibly due to solid-js latest version.

@Canna71
Copy link

Canna71 commented Jul 28, 2024

Just did a PR for this.

@Tjerk-Haaye-Henricus
Copy link

Hey there :) Will the PB gonna be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants