fix: add a11y features to input password #1232
Draft
+137
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
Fupete
force-pushed
the
1216-componente-input-indagare-ulteriormente-la-variante-password-navigando-da-tastiera-o-con-screen-reader
branch
from
b4ec891
to
bbbe4b4
Compare
…-la-variante-password-navigando-da-tastiera-o-con-screen-reader
Fupete
commented
Oct 1, 2024
|
|
||
| _getCompletedRequirements(password) { | ||
| const requirements = [ | ||
| { test: password.length >= 8, description: 'Almeno 8 caratteri.' }, |
There was a problem hiding this comment.
@astagi due to do secondo me:
- C'è da capire se e come spostare le description di questi requirements nei Default iniziali. E se dare la possibilità di cambiarli da data-bs.
- C'è da capire se dare la possibilità di mostrare anche a video questi requirement soddisfatti o no in tempo reale. Se lasciarli come in questa versione solo per screen reader. O se metterli come opzione mostrati a vice magari usando un default.showStrengthSuggestions true/false.
- C'è da capire se incorporare così i requirements (come già oggi), sia corretto... o sia meglio lasciare allo sviluppatore e qui lasciare solo la parte visiva. O integrare un plugin node nuovo, da trovare.
There was a problem hiding this comment.
⬆️ Solo appunti di alcune cose che dovremo discutere al prox hands-on.
Fupete
added
a11y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1216
Obiettivi: