Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency with sd-jwt-python #281

Closed
peppelinux opened this issue Oct 22, 2024 · 1 comment
Closed

remove dependency with sd-jwt-python #281

peppelinux opened this issue Oct 22, 2024 · 1 comment
Assignees
@LadyCodesItBetter
Labels
done enhancement Something improving existing features
Milestone
0.9.1

Comments

@peppelinux
Copy link
Member

@Zicchio has introduced the support of sd-jwt within this SDK, here:
https://github.com/italia/eudi-wallet-it-python/pull/277/files#diff-c2260eb7da4a0da1686cdfce91f958dd87d554fffd35df96f0c79aaebef2bc02

in the form used by @Zicchio he deligns the removal of sd-jwt-python as project dependency.

@PascalDR I need you to individuate all the parts that still uses sd-jwt-python, their intended usage and I ask you to extend the current approach of @Zicchio 's sd_jwt.py including all the uncovered feature we might need, before the removal of sd-jwt as package.
@peppelinux peppelinux added the enhancement Something improving existing features label Oct 22, 2024
@peppelinux peppelinux added this to the 0.9.1 milestone Oct 22, 2024
@peppelinux peppelinux mentioned this issue Oct 23, 2024
Closed
@peppelinux peppelinux moved this to In Progress in EUDI WALLET IT Python Nov 4, 2024
@LadyCodesItBetter LadyCodesItBetter mentioned this issue Nov 5, 2024
Merged
peppelinux added a commit that referenced this issue Nov 14, 2024
@LadyCodesItBetter @peppelinux
Feature/#281 remove dependency with sd jwt python (#297)
335bece 
* feat: removed sd-jwt external library dependency

* feat: added tests

* switch from jwcrypto to cryptojwt

* feat: add documentation

* fix: flat old layers

* Update pyeudiw/sd_jwt/common.py

Co-authored-by: Giuseppe De Marco <[email protected]>

* Update docs/SD-JWT.md

Co-authored-by: Giuseppe De Marco <[email protected]>

* Update pyeudiw/openid4vp/authorization_response.py

Co-authored-by: Giuseppe De Marco <[email protected]>

* Update pyeudiw/sd_jwt/holder.py

Co-authored-by: Giuseppe De Marco <[email protected]>

* fix: old types and continue flatting

* fix: removing translation layer for jwcrypto library

* wip: issues are confined on sd_jwt folder

* wip: holder fixed

* wip: json serialization format management

---------

Co-authored-by: Giuseppe De Marco <[email protected]>
@Zicchio Zicchio mentioned this issue Nov 28, 2024
Closed
@peppelinux
Copy link
Member Author

Resolved by #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LadyCodesItBetter LadyCodesItBetter

Labels
done enhancement Something improving existing features
Projects
EUDI WALLET IT Python
Status: Done
Milestone
0.9.1
Development

No branches or pull requests
3 participants
@peppelinux @PascalDR @LadyCodesItBetter