#299-feature/presentation submission dynamic handler #314
+282
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
reviewed
Nov 22, 2024
peppelinux
reviewed
Nov 22, 2024
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| class PresentationSubmission: |
There was a problem hiding this comment.
don't put the classes within the init file
we are going to refactor all the code within this project to remove this code-style in favour or a proper division of files by scopes
peppelinux
reviewed
Nov 22, 2024
| ImportError: If a module or class cannot be loaded. | ||
| """ | ||
| handlers = {} | ||
|
|
There was a problem hiding this comment.
please create and add a pydantic schema validation here for the prensentation_submission object
There was a problem hiding this comment.
please put some limits on the presentation submission size, in a way that an attacker might not push 10mb of presentation submission causing resource exaustion to the RP
There was a problem hiding this comment.
I've added control for byte size and credential number too
Co-authored-by: Giuseppe De Marco <[email protected]>
…om:LadyCodesItBetter/eudi-wallet-it-python into feature/italia#299-Presentation-Submission
… for descriptor_map
peppelinux
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces enhancements to the PresentationSubmission class to improve error handling and dynamic handler initialization based on descriptor_map.
Key points: