Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Userinfo response content-type for spid is wrong #290

Closed
matteo-s opened this issue Dec 13, 2023 · 2 comments
Closed

Userinfo response content-type for spid is wrong #290

matteo-s opened this issue Dec 13, 2023 · 2 comments
Assignees
@rglauco

Comments

@matteo-s
Copy link

The docs at https://docs.italia.it/italia/spid/spid-cie-oidc-docs/it/versione-corrente/userinfo_endpoint.html#response say that userinfo response content-type MUST be application/jwt for spid. For CIE I could not find any requirement.

La response dello UserInfo Endpoint DEVE specificare nel "Content-Type" il valore "application/jwt".

The current implementation always returns application/jose as type.

spid-cie-oidc-django/spid_cie_oidc/provider/views/userinfo_endpoint.py

Line 105 in 2b0c2ef

return HttpResponse(jwe, content_type="application/jose")

@rglauco rglauco self-assigned this Dec 13, 2023
@peppelinux
Copy link
Member

https://www.iana.org/assignments/media-types/media-types.xhtml

includes both jose and JWT, I'm in favor to align to application/jwt since jose includes also JWS using json serialization, while JWT only uses compact serialization

@rglauco
Copy link
Collaborator

rglauco commented Dec 14, 2023 •
edited
Loading

Verified with IPZS, uniformed use of application/jwt for both SPID and CIE. fixed in #291

Closed
lgiucastro-datanetwork added a commit to lgiucastro-datanetwork/spid-cie-oidc-aspnetcore that referenced this issue May 7, 2024
@lgiucastro-datanetwork
Update CustomHttpClientHandler.cs
127a976 
Fix userinfo response - wrong content-type (application/jose)
following the modification at: italia/spid-cie-oidc-django#290

should resolve these issues:
italia#24
italia#25
Closed
@danielegiallonardo danielegiallonardo mentioned this issue May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rglauco rglauco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peppelinux @matteo-s @rglauco