Cie Integration #311
Merged
Cie Integration #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
bump to 1.3.3
peppelinux
requested changes
Mar 11, 2024
peppelinux
requested changes
Mar 11, 2024
| @@ -263,7 +263,6 @@ def set_jwks_as_array(self): | |||
| setattr(self, i, [value]) | |||
|
|
|||
| def save(self, *args, **kwargs): | |||
| self.entity_type = self.type[0] | |||
There was a problem hiding this comment.
perché è rimosso? prende il primo entity type disponibile come quello default
There was a problem hiding this comment.
Perché quando si modifica l'EC di un RP nel db viene salvato il valore federation_entity a prescindere dal valore della select, che sta in self.type[1] e non viene preso
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
peppelinux
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added distinction between key usage during RP and OP operations
Added example encryption keys in TA->RP and RP db dumps
Added encryption algs to metadata validator
Fixed entity_type save method