Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another measurement type #23

Open
brettonw opened this issue Aug 28, 2022 · 6 comments
Open

Another measurement type #23

brettonw opened this issue Aug 28, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@brettonw
Copy link
Contributor

The new Liquid Level Sensor reports units:

{
did: "1_P3",
type: "in",
name: "LLS",
value: 5.8
},

From the "config":

mconf: [
{
abaddr: 1,
name: "module_1",
hwtype: "FMM",
update: false,
updateStat: 0,
extra: {
swapAddr: 0,
auto: [
true,
true,
false,
false
],
mode: [
"wof",
"wof",
"LLS-15",
"LLS-15"
],
flowMode: "gph",
levelMode: "in"
}
},

Without a unit on the sensor, a history graph just shows a color bar representing different values.

Mine is configured for "inches". I'm not sure if a non-US configuration will report "cm".

@brettonw
Copy link
Contributor Author

Can I buy you another coffee? :)

@brettonw
Copy link
Contributor Author

brettonw commented Aug 28, 2022

FWIW, I used the customize feature to work around this.

  customize:
    sensor.apex_salt:
      unit_of_measurement: ppt
    sensor.apex_lls:
      unit_of_measurement: in

@itchannel
Copy link
Owner

Thanks. I can easily add these types in so any you find let me know and I'll add them to the next release.

If only I had every Apex module but keeping reef tanks get very expensive :)

@itchannel itchannel added the enhancement New feature or request label Aug 28, 2022
@itchannel itchannel self-assigned this Aug 28, 2022
@brettonw
Copy link
Contributor Author

brettonw commented Aug 28, 2022

Another approach would be to set the state_class of all the sensor types to 'measurement':

        self._attr_state_class = SensorStateClass.MEASUREMENT

in ApexSensor.init

@itchannel
Copy link
Owner

Interesting will check that out

@itchannel
Copy link
Owner

Can I buy you another coffee? :)

Thanks for the coffee 👍

@brettonw brettonw mentioned this issue Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants