Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP archives with an uppercase extension (*.ZIP) are not detected as such, and probably more #5

Open
Rackover opened this issue Mar 30, 2022 · 1 comment

Comments

@Rackover
Copy link

boar/probe.go

Line 236 in d2befc0

switch ext {

hello! I cannot write in golang otherwise I would have made a PR directly. But I think a toLowerCase call, or equivalent, is required there on the extension check. Otherwise uppercase ZIP files cannot be installed by the itch game launcher.

image
image

I've seen other people have this problem so this fix might help more than one :) have a good day!

@leafo
Copy link
Member

leafo commented Mar 31, 2022

The extension is normalized to lowercase here:

boar/probe.go

Line 227 in d2befc0

lowerName := strings.ToLower(stats.Name())

Error is being triggered here:

https://github.com/itchio/hush/blob/67599c10234330cdd2afa465bcec3ffbb3221d52/get_installer_info.go#L33

In the meantime I recommend using lowercase file extensions. If you are using butler to upload your game then it will automatically use an appropriate file extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants