Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle characters with different encodings #4

Open
leafo opened this issue Jul 29, 2017 · 1 comment
Open

Handle characters with different encodings #4

leafo opened this issue Jul 29, 2017 · 1 comment
Assignees

Comments

@leafo
Copy link
Member

leafo commented Jul 29, 2017

filenames with characters that aren't utf-8 encoded will cause the extraction to fail. We should be able to automatically convert between the encoding to avoid the error.

https://twitter.com/Tryall_YT/status/891304284284997632

Go throws the error: 'ERROR: invalid byte sequence for encoding "UTF8"

@fasterthanlime
Copy link
Collaborator

Sooooooooo

Paths encoding in .zip are a bit of a mess (in practice) (/cc @GranPC)

In theory, zip has a flag that you can set that says "all the paths are UTF-8" - if it's not set, then... they can be anything.

We've had a similar problem with butler's unzip command (for the app) and Jesus is working on a method that autodetects the encoding of paths if the utf-8 flag is not set. It hasn't landed yet, but when it does, we should switch zipserver over to https://github.com/itchio/arkive, which will solve this issue.

@fasterthanlime fasterthanlime self-assigned this Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants