Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary installers no longer attached to Github releases #9700

Closed
michaelstepner opened this issue Jul 4, 2023 · 8 comments · Fixed by #9703
Closed

Binary installers no longer attached to Github releases #9700

michaelstepner opened this issue Jul 4, 2023 · 8 comments · Fixed by #9703

Comments

@michaelstepner
Copy link

Bug Report

Binaries no longer attached to release

Description

For all releases until dvc v3.1.0, the tagged release on Github had binary installers attached as assets:

image

For releases since then (v3.2.0 onward), no binary assets are attached:

image

Reproduce

View dvc releases page.

Expected

I hope this regression was unintentional, and there will be interest in restoring the versioned binary installers associated with each release.

In my own experience, these installers are very useful for CI/CD environments. It is helpful to pin to a specific version and test upgrades before deploying. I'm sure other users have other uses as well.

@efiop
Copy link
Contributor

efiop commented Jul 4, 2023

Hi @michaelstepner Those binaries were not official, please see #9627 (comment)

@efiop efiop closed this as completed Jul 4, 2023
@efiop
Copy link
Contributor

efiop commented Jul 4, 2023

Ah, looks like we need to update our plack in the readme too, reopening

@efiop
Copy link
Contributor

efiop commented Jul 4, 2023

@michaelstepner If you need direct links, you could use ones from dvc.org, e.g. https://dvc.org/download/linux-deb/dvc-3.2.1 Would that work for you?

@michaelstepner
Copy link
Author

@efiop the download link on dvc.org works great. Two comments/requests:

  1. I hope you'll continue hosting installers for outdated binaries, to facilitate version pinning in dependent software. If you don't plan to keep the binaries posted for older versions, it would be helpful if you let us know so that we can cache them as needed.
  2. The best of all worlds would be if you include links to the dvc.org installers as text in your Github releases. For example:

📦 Installers

@michaelstepner
Copy link
Author

One other note @efiop: it seems that the releases linked on dvc.org are not automatically synced with the latest version released on Github. Right now, the version history on Github is:

  • v3.4.0 (17 hours ago)
  • v3.3.1 (2 days ago)
  • v3.3.0 (2 days ago)
  • v3.2.4 (4 days ago)
    • This is the version linked on dvc.org

Perhaps that's intentional behaviour so that you stagger releases to the public? But if not, you might wish to incorporate an update to dvc.org links as part of your CD pipeline.

If you'd like me to open Issues with feature requests for any of the items I've mentioned here, let me know.

@efiop
Copy link
Contributor

efiop commented Jul 4, 2023

The best of all worlds would be if you include links to the dvc.org installers as text in your Github releases. For example:

Github releases happen before packages are available. Doesn't seem reasonable to do that at this point, from what I can see. Also note that those packages are really completely separate from the main github project (same as conda/snap/brew/etc), so a product release (which includes packages) is really on dvc.org and not on our github.

One other note @efiop: it seems that the releases linked on dvc.org are not automatically synced with the latest version released on Github. Right now, the version history on Github is:

They are not, dvc.org is updated only when all packages are available for a certain version (usually happens within a few days).

@efiop
Copy link
Contributor

efiop commented Jul 4, 2023

@michaelstepner Regarding caching, we do indeed preserve old versions. If you were able to download some version once - you will be able to download it later. That being said, I don't know what kind setup requirements you might have in your particular case, maybe it would make sense to cache it yourself somewhere as well.

@michaelstepner
Copy link
Author

Thanks for clarifying @efiop, I'll use the dvc.org links going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants